Issue 3450005: Added crypto library to update_engine -l list so that it is explicitly passed to the linker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3450005: Added crypto library to update_engine -l list so that it is explicitly passed to the linker. (Closed)

Created:
10 years, 3 months ago by raymes

Modified:
9 years, 7 months ago

Reviewers:
petkov, adlr

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
http://git.chromium.org/git/update_engine.git

Visibility:
Public.

Description

Added crypto library to update_engine -l list so that it is explicitly passed to the linker. Without this, the package won't link with the gold linker. This is not a gold bug. Change-Id: If52f8ba2630f017e9482de1cdd9c9f34a54e8ffe BUG= TEST= Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e3d8d4c

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	SConstruct	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

raymes

On 2010/09/14 21:51:03, raymes wrote: > Please review my change. Ping

10 years, 3 months ago (2010-09-17 17:17:02 UTC) #2

adlr

10 years, 3 months ago (2010-09-17 17:18:29 UTC) #3

sorry for the delay.

LGTM thanks!

On Fri, Sep 17, 2010 at 10:17 AM, <raymes@chromium.org> wrote:

> On 2010/09/14 21:51:03, raymes wrote:
>
>> Please review my change.
>>
>
> Ping
>
>
> http://codereview.chromium.org/3450005/show
>

Expand Messages | Collapse Messages