Issue 3450004: Deprecated libcrash.a so stop testing it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3450004: Deprecated libcrash.a so stop testing it (Closed)

Created:
10 years, 3 months ago by kmixter1

Modified:
9 years, 7 months ago

Reviewers:
sosa

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org

Base URL:
http://git.chromium.org/git/autotest.git

Visibility:
Public.

Description

Deprecated libcrash.a so stop testing it Change-Id: I423046b2e56433123b7eb3ae6f26f575bf3738dd BUG=5870 TEST=logging_UserCrash

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove all traces of with-breakpad tests #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -60 lines)			Patch
	M	client/site_tests/logging_UserCrash/logging_UserCrash.py	View	1	14 chunks	+33 lines, -55 lines	0 comments	Download
	M	client/site_tests/logging_UserCrash/src/Makefile	View		2 chunks	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sosa

10 years, 3 months ago (2010-09-14 22:49:37 UTC) #2

LGTM w/ nit

http://codereview.chromium.org/3450004/diff/1/2
File client/site_tests/logging_UserCrash/logging_UserCrash.py (right):

http://codereview.chromium.org/3450004/diff/1/2#newcode75
client/site_tests/logging_UserCrash/logging_UserCrash.py:75: for with_breakpad
in [False]:
Remove the for loop :)

Expand Messages | Collapse Messages