Issue 3448023: autotest: Stash away cryptohomed.log to help diagnose login issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3448023: autotest: Stash away cryptohomed.log to help diagnose login issues (Closed)

Created:
10 years, 3 months ago by kmixter1

Modified:
9 years, 7 months ago

Reviewers:
Chris Masone, fes, truty1

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org

Base URL:
http://git.chromium.org/git/autotest.git

Visibility:
Public.

Description

autotest: Stash away cryptohomed.log to help diagnose login issues Change-Id: I8333131a9d88162792bd5865ba2c3ef8123db34f BUG=6883 TEST=Ran desktopui_ChromeFirstRender, verified cryptohomed.log in results Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e1fc460

Patch Set 1 #

Total comments: 1

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	client/bin/chromeos_constants.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	client/bin/site_ui_test.py	View		1 chunk	+5 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

truty1

http://codereview.chromium.org/3448023/diff/1/3 File client/bin/site_ui_test.py (right): http://codereview.chromium.org/3448023/diff/1/3#newcode262 client/bin/site_ui_test.py:262: base = os.path.basename(chromeos_constants.CRYPTOHOMED_LOG) should this be in a try ...

10 years, 3 months ago (2010-09-24 00:27:27 UTC) #2

LGTM other than truty1's comment.

Expand Messages | Collapse Messages