Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: bin/cros_make_image_bootable

Issue 3448022: build_image: Merge x86 and ARM where possible. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/crosutils.git
Patch Set: Codereview ate my homework. Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build_gpt.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bin/cros_make_image_bootable
diff --git a/bin/cros_make_image_bootable b/bin/cros_make_image_bootable
index 8aacf8c913ead22d838f6cdf0c119da4272dfa70..20c21911d66bc4330e17083e44ebc4fda562dc6d 100755
--- a/bin/cros_make_image_bootable
+++ b/bin/cros_make_image_bootable
@@ -86,9 +86,6 @@ DEFINE_integer verity_max_ios 1024 \
DEFINE_string verity_algorithm "sha1" \
"Cryptographic hash algorithm used for kernel vboot."
-DEFINE_string arm_extra_bootargs "" \
- "Additional command line options to pass to the ARM kernel."
-
DEFINE_string keys_dir "/usr/share/vboot/devkeys" \
"Directory containing the signing keys."
@@ -199,8 +196,7 @@ make_image_bootable() {
sudo dd if="${FLAGS_output_dir}/vmlinuz.image" of="${image}" \
conv=notrunc bs=512 seek=${koffset}
- # Update the bootloaders. For legacy/efi x86, the EFI system partition
- # will be updated and for arm, the mbr will be updated (for u-boot).
+ # Update the bootloaders. The EFI system partition will be updated.
local kernel_part=
local usb_disk="${FLAGS_usb_disk}"
@@ -218,17 +214,8 @@ make_image_bootable() {
# Install syslinux on the EFI System Partition.
kernel_part="${kernel_part} --install_syslinux"
elif [[ "${FLAGS_arch}" = "arm" ]]; then
- # TODO(wad) mmcblk1p3 is hardcoded for arm for now!
- usb_disk="/dev/mmcblk1p3"
- # ARM doesn't support using the kernel image for kernel cmdline flags yet.
- kernel_part="--kernel_cmdline=\"${FLAGS_arm_extra_bootargs}\" "
- # TODO(wad) Integrate dmtable extraction into the arm build
- # E.g. $(cat ${FLAGS_output_dir}/boot.config | tr -s '\n' ' ')"
- local kpart_offset="--kernel_partition_offset=${koffset}"
- local kpart_size="--kernel_partition_sectors="
- kpart_size="${kpart_size}$(partsize ${image} 2)"
- kernel_part="${kernel_part} ${kpart_size} ${kpart_offset}"
- info "Using addition bootloader arguments: ${kernel_part}"
+ # These flags are not used for ARM update_bootloaders.sh
+ kernel_part=""
fi
# Update partition 12
« no previous file with comments | « no previous file | build_gpt.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698