Issue 3448001: Revert back to use exec() instead of execfile().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3448001: Revert back to use exec() instead of execfile(). (Closed)

Created:
10 years, 3 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
laforge

CC:
chromium-reviews, M-A Ruel

Visibility:
Public.

Description

Revert back to use exec() instead of execfile(). It seems execfile() has different properties than exec(). TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59407

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	drover.py	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

laforge

10 years, 3 months ago (2010-09-14 18:49:44 UTC) #2

LGTM, thank you

On Tue, Sep 14, 2010 at 11:08 AM, <maruel@chromium.org> wrote:

> Reviewers: laforge,
>
> Description:
> Revert back to use exec() instead of execfile().
>
> It seems execfile() has different properties than exec().
>
> TEST=none
> BUG=none
>
> Please review this at http://codereview.chromium.org/3448001/show
>
> Affected files:
>  M drover.py
>
>
> Index: drover.py
> diff --git a/drover.py b/drover.py
> index
>
2f726a5d19fdc6b0a9c6f2022694bfdae7732c8e..8a56e2a3e21f22aa4bc7ce8907e7a2535123dce1
> 100755
> --- a/drover.py
> +++ b/drover.py
> @@ -403,7 +403,9 @@ def drover(options, args):
>   global file_pattern_
>   if os.path.exists("drover.properties"):
>     FILE_PATTERN = file_pattern_
> -    execfile("drover.properties")
> +    f = open("drover.properties")
> +    exec(f)
> +    f.close()
>     if FILE_PATTERN:
>       file_pattern_ = FILE_PATTERN
>
>
>
>

Expand Messages | Collapse Messages