Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: chrome/installer/util/version.cc

Issue 3447008: base: Finish moving the SplitString functions from string_util.h to string_split.h (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: chromeos fixes Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/installer/util/version.h" 5 #include "chrome/installer/util/version.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/format_macros.h" 9 #include "base/format_macros.h"
10 #include "base/string_number_conversions.h" 10 #include "base/string_number_conversions.h"
11 #include "base/string_split.h"
11 #include "base/string_util.h" 12 #include "base/string_util.h"
12 #include "base/utf_string_conversions.h" 13 #include "base/utf_string_conversions.h"
13 #include "chrome/installer/util/version.h" 14 #include "chrome/installer/util/version.h"
14 15
15 installer::Version::Version(int64 major, int64 minor, int64 build, 16 installer::Version::Version(int64 major, int64 minor, int64 build,
16 int64 patch) 17 int64 patch)
17 : major_(major), 18 : major_(major),
18 minor_(minor), 19 minor_(minor),
19 build_(build), 20 build_(build),
20 patch_(patch) { 21 patch_(patch) {
(...skipping 25 matching lines...) Expand all
46 return NULL; 47 return NULL;
47 } 48 }
48 49
49 int64 v0, v1, v2, v3; 50 int64 v0, v1, v2, v3;
50 base::StringToInt64(numbers[0], &v0); 51 base::StringToInt64(numbers[0], &v0);
51 base::StringToInt64(numbers[1], &v1); 52 base::StringToInt64(numbers[1], &v1);
52 base::StringToInt64(numbers[2], &v2); 53 base::StringToInt64(numbers[2], &v2);
53 base::StringToInt64(numbers[3], &v3); 54 base::StringToInt64(numbers[3], &v3);
54 return new Version(v0, v1, v2, v3); 55 return new Version(v0, v1, v2, v3);
55 } 56 }
OLDNEW
« no previous file with comments | « chrome/installer/util/shell_util.cc ('k') | chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698