Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Side by Side Diff: base/string_split_unittest.cc

Issue 3447008: base: Finish moving the SplitString functions from string_util.h to string_split.h (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: chromeos fixes Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/string_split.cc ('k') | base/string_util.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/string_split.h" 5 #include "base/string_split.h"
6 #include "testing/gmock/include/gmock/gmock.h" 6 #include "testing/gmock/include/gmock/gmock.h"
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 using ::testing::ElementsAre; 9 using ::testing::ElementsAre;
10 10
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 EXPECT_EQ("value2", kv_pairs[1].second); 132 EXPECT_EQ("value2", kv_pairs[1].second);
133 } 133 }
134 134
135 TEST(SplitStringUsingSubstrTest, EmptyString) { 135 TEST(SplitStringUsingSubstrTest, EmptyString) {
136 std::vector<std::string> results; 136 std::vector<std::string> results;
137 SplitStringUsingSubstr("", "DELIMITER", &results); 137 SplitStringUsingSubstr("", "DELIMITER", &results);
138 ASSERT_EQ(1u, results.size()); 138 ASSERT_EQ(1u, results.size());
139 EXPECT_THAT(results, ElementsAre("")); 139 EXPECT_THAT(results, ElementsAre(""));
140 } 140 }
141 141
142 // Test for SplitString
143 TEST(StringUtilTest, SplitString) {
144 std::vector<std::wstring> r;
145
146 SplitString(L"", L',', &r);
147 ASSERT_EQ(1U, r.size());
148 EXPECT_EQ(r[0], L"");
149 r.clear();
150
151 SplitString(L"a,b,c", L',', &r);
152 ASSERT_EQ(3U, r.size());
153 EXPECT_EQ(r[0], L"a");
154 EXPECT_EQ(r[1], L"b");
155 EXPECT_EQ(r[2], L"c");
156 r.clear();
157
158 SplitString(L"a, b, c", L',', &r);
159 ASSERT_EQ(3U, r.size());
160 EXPECT_EQ(r[0], L"a");
161 EXPECT_EQ(r[1], L"b");
162 EXPECT_EQ(r[2], L"c");
163 r.clear();
164
165 SplitString(L"a,,c", L',', &r);
166 ASSERT_EQ(3U, r.size());
167 EXPECT_EQ(r[0], L"a");
168 EXPECT_EQ(r[1], L"");
169 EXPECT_EQ(r[2], L"c");
170 r.clear();
171
172 SplitString(L"", L'*', &r);
173 ASSERT_EQ(1U, r.size());
174 EXPECT_EQ(r[0], L"");
175 r.clear();
176
177 SplitString(L"foo", L'*', &r);
178 ASSERT_EQ(1U, r.size());
179 EXPECT_EQ(r[0], L"foo");
180 r.clear();
181
182 SplitString(L"foo ,", L',', &r);
183 ASSERT_EQ(2U, r.size());
184 EXPECT_EQ(r[0], L"foo");
185 EXPECT_EQ(r[1], L"");
186 r.clear();
187
188 SplitString(L",", L',', &r);
189 ASSERT_EQ(2U, r.size());
190 EXPECT_EQ(r[0], L"");
191 EXPECT_EQ(r[1], L"");
192 r.clear();
193
194 SplitString(L"\t\ta\t", L'\t', &r);
195 ASSERT_EQ(4U, r.size());
196 EXPECT_EQ(r[0], L"");
197 EXPECT_EQ(r[1], L"");
198 EXPECT_EQ(r[2], L"a");
199 EXPECT_EQ(r[3], L"");
200 r.clear();
201
202 SplitString(L"\ta\t\nb\tcc", L'\n', &r);
203 ASSERT_EQ(2U, r.size());
204 EXPECT_EQ(r[0], L"a");
205 EXPECT_EQ(r[1], L"b\tcc");
206 r.clear();
207 }
208
142 TEST(SplitStringUsingSubstrTest, StringWithNoDelimiter) { 209 TEST(SplitStringUsingSubstrTest, StringWithNoDelimiter) {
143 std::vector<std::string> results; 210 std::vector<std::string> results;
144 SplitStringUsingSubstr("alongwordwithnodelimiter", "DELIMITER", &results); 211 SplitStringUsingSubstr("alongwordwithnodelimiter", "DELIMITER", &results);
145 ASSERT_EQ(1u, results.size()); 212 ASSERT_EQ(1u, results.size());
146 EXPECT_THAT(results, ElementsAre("alongwordwithnodelimiter")); 213 EXPECT_THAT(results, ElementsAre("alongwordwithnodelimiter"));
147 } 214 }
148 215
149 TEST(SplitStringUsingSubstrTest, LeadingDelimitersSkipped) { 216 TEST(SplitStringUsingSubstrTest, LeadingDelimitersSkipped) {
150 std::vector<std::string> results; 217 std::vector<std::string> results;
151 SplitStringUsingSubstr( 218 SplitStringUsingSubstr(
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 r.clear(); 256 r.clear();
190 257
191 SplitStringDontTrim(L"\ta\t\nb\tcc", L'\n', &r); 258 SplitStringDontTrim(L"\ta\t\nb\tcc", L'\n', &r);
192 ASSERT_EQ(2U, r.size()); 259 ASSERT_EQ(2U, r.size());
193 EXPECT_EQ(r[0], L"\ta\t"); 260 EXPECT_EQ(r[0], L"\ta\t");
194 EXPECT_EQ(r[1], L"b\tcc"); 261 EXPECT_EQ(r[1], L"b\tcc");
195 r.clear(); 262 r.clear();
196 } 263 }
197 264
198 } // namespace base 265 } // namespace base
OLDNEW
« no previous file with comments | « base/string_split.cc ('k') | base/string_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698