Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 3446025: Add performance macros; fix assert macro (Closed)

Created:
10 years, 3 months ago by Randall Spangler
Modified:
9 years, 7 months ago
Reviewers:
Luigi Semenzato
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Add performance macros. When enabled, these are defined in each platform's biosincludes.h. Fix assert() macro to only be defined #ifdef VBOOT_DEBUG Change-Id: I4a65c408544cd4319628c4ad20ed46eafebe69c9 BUG=chrome-os-partner:1207 TEST=manual Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c93347b

Patch Set 1 #

Patch Set 2 : Fix missing #ifdef around assert macro #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M firmware/include/utility.h View 1 1 chunk +22 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Randall Spangler
10 years, 2 months ago (2010-10-04 17:07:27 UTC) #1
Luigi Semenzato
10 years, 2 months ago (2010-10-04 17:42:01 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698