Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 3446006: Temporary workaround to fix make_chroot --fast (Closed)

Created:
10 years, 3 months ago by davidjames
Modified:
9 years, 4 months ago
Reviewers:
Nick Sanders
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Temporary workaround to fix make_chroot --fast Three changes here: 1) parallel_emerge now only disables PORTAGE_LOCKS on board builds. This slows down make_chroot --fast, but works around a bug where make_chroot --fast sometimes merges broken packages. 2) Only set PORTAGE_LOCKS if it's not already set. This allows users to override PORTAGE_LOCKS and request that it be enabled using PORTAGE_LOCKS=true 3) Only add the no-env-update feature if PORTAGE_LOCKS=false. This feature is only needed for that case. Long term fix is to patch PORTAGE_LOCKS feature to lock postinst. That'll be tracked in a separate bug. BUG=chromium-os:6750 TEST=Run make_chroot --fast. It works every time now, but is slower. build_packages && build_image run at same speed as before. Change-Id: I12ab40671034e10cd2ffbba45281ca44718d1d2c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M parallel_emerge View 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
davidjames
10 years, 3 months ago (2010-09-15 20:09:25 UTC) #1
Nick Sanders
10 years, 3 months ago (2010-09-15 22:44:51 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698