Issue 3446002: cros_workon: WORKON_FILE should be owned by the user

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3446002: cros_workon: WORKON_FILE should be owned by the user (Closed)

Created:
10 years, 3 months ago by Mandeep Singh Baines

Modified:
9 years, 7 months ago

Reviewers:
davidjames, zbehan

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

cros_workon: WORKON_FILE should be owned by the user BUG=none TEST=Verified that WORKON_FILE is now owned by the user. Change-Id: I32f05d5de5177756945b6f5bc037a2f738ffffe5

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
	M	cros_workon	View		2 chunks	+9 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

zbehan

10 years, 3 months ago (2010-09-15 18:32:10 UTC) #3

Sorry, I got into daydreaming of how nice it would be to drop the "TODO:
remove compatibility" and just put it forever in the chroot upgrade script.
Oh well.

LGTM

On Wed, Sep 15, 2010 at 11:28 AM, <msb@chromium.org> wrote:

> ping
>
>
> http://codereview.chromium.org/3446002/show
>

Expand Messages | Collapse Messages