Issue 3444009: Merge 67734 - createBlobURL with no argument causes crash....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3444009: Merge 67734 - createBlobURL with no argument causes crash.... (Closed)

Created:
10 years, 3 months ago by jianli

Modified:
9 years, 6 months ago

Reviewers:
jianli

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/517/

Visibility:
Public.

Description

Merge 67734 - createBlobURL with no argument causes crash. https://bugs.webkit.org/show_bug.cgi?id=45880 Reviewed by Dmitry Titov. WebCore: The fix is to check if the passing blob argument is NULL or not. Test: fast/files/create-blob-url-crash.html * dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::createPublicBlobURL): * page/DOMWindow.idl: Add attribute to convert null string to undefined. LayoutTests: * fast/files/create-blob-url-crash-expected.txt: Added. * fast/files/create-blob-url-crash.html: Added. BUG=56272 TEST=create-blob-url-crash.html TBR=jianli@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67742

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, --1 lines)			Patch
A +	LayoutTests/fast/files/create-blob-url-crash.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/fast/files/create-blob-url-crash-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	WebCore/dom/ScriptExecutionContext.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	WebCore/page/DOMWindow.idl	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages