linux: Pass -pipe to gcc.

linux: Pass -pipe to gcc.

This was marginally faster in my local test on one file.

TEST=compiles

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59583

[Elliot Glaysher, 2010-09-15 22:43:20]

Therefore it will be faster everywhere! LGTM.

On Wed, Sep 15, 2010 at 3:40 PM,  <evan@chromium.org> wrote:
> Reviewers: Elliot Glaysher,
>
> Description:
> linux: Pass -pipe to gcc.
>
> This was marginally faster in my local test on one file.
>
> TEST=compiles
>
> Please review this at http://codereview.chromium.org/3444006/show
>
> SVN Base: http://src.chromium.org/git/chromium.git
>
> Affected files:
>  M build/common.gypi
>
>
> Index: build/common.gypi
> diff --git a/build/common.gypi b/build/common.gypi
> index
>
9b68623d20014fb8554664c914952dfcb71b236f..c78503cf20443ed3e067f6b9eaefda60f6481c95
> 100644
> --- a/build/common.gypi
> +++ b/build/common.gypi
> @@ -835,6 +835,7 @@
>           # Don't export any symbols (for example, to plugins we dlopen()).
>           # Note: this is *required* to make some plugins work.
>           '-fvisibility=hidden',
> +          '-pipe',
>         ],
>         'cflags_cc': [
>           '-fno-rtti',
>
>
>

[Lei Zhang, 2010-09-15 22:45:29]

LGTM.

I wonder what the actual speedup is.

Patch set 1 only affects OS_POSIX - OS_MACOSX. Is there going to be a separate
CL for Mac?

[Lei Zhang, 2010-09-16 00:12:29]

On 2010/09/15 22:45:29, Lei Zhang wrote:
> LGTM.
> 
> I wonder what the actual speedup is.

Didn't really improve building the chrome target for me on my Z600, but YMMV.

[Evan Martin, 2010-09-16 00:14:49]

On 2010/09/16 00:12:29, Lei Zhang wrote:
> Didn't really improve building the chrome target for me on my Z600, but YMMV.

I'm hoping to see it on
http://build.chromium.org/buildbot/waterfall/stats/Chromium%20Linux
on the compile time graph.

[Evan Martin, 2010-09-16 00:26:34]

On 2010/09/16 00:14:49, Evan Martin wrote:
> On 2010/09/16 00:12:29, Lei Zhang wrote:
> > Didn't really improve building the chrome target for me on my Z600, but
YMMV.
> 
> I'm hoping to see it on
> http://build.chromium.org/buildbot/waterfall/stats/Chromium%2520Linux
> on the compile time graph.

It didn't help in one cycle.  Even for our full builds it appears we use
distcc/ccache, so -pipe will only affect files that have *changed* between
builds, which is a relatively small number.  I'll see if the graphs ever improve
over the next few days.

[Evan Martin, 2010-09-16 19:48:08]

Looking now, it maybe shaved off like 20sec, but that could just be due to small
changes happening since my patch.

PS: mac already uses -pipe