Issue 3443017: Committing http://codereview.chromium.org/3420004/show for grt@...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3443017: Committing http://codereview.chromium.org/3420004/show for grt@... (Closed)

Created:
10 years, 3 months ago by robertshield

Modified:
9 years, 6 months ago

Reviewers:

CC:
chromium-reviews, amit, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Committing http://codereview.chromium.org/3420004/show for grt@ Original description: - added detection of IE9 for ChromeFrame.IEVersion metric - replaced ChromeFrame.FullTabLaunchType metric with ChromeFrame.LaunchType metric, which logs more info regarding how it came to be that GCF rendered a page (but only for the CTransaction patch) BUG=43885 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60188

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+143 lines, -73 lines)			Patch
M	chrome_frame/bho.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome_frame/chrome_active_document.cc	View		2 chunks	+15 lines, -5 lines	0 comments	Download
M	chrome_frame/chrome_frame_activex.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome_frame/chrome_frame_activex_base.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome_frame/http_negotiate.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome_frame/protocol_sink_wrap.h	View		2 chunks	+1 line, -7 lines	0 comments	Download
M	chrome_frame/protocol_sink_wrap.cc	View		13 chunks	+49 lines, -39 lines	0 comments	Download
M	chrome_frame/test/chrome_frame_test_utils.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome_frame/test/util_unittests.cc	View		2 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome_frame/urlmon_bind_status_callback.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome_frame/utils.h	View		2 chunks	+33 lines, -1 line	0 comments	Download
M	chrome_frame/utils.cc	View	1	5 chunks	+27 lines, -10 lines	0 comments	Download