Issue 3443005: Added ext library to chrontel -l list so that it is explicitly passed to the linker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3443005: Added ext library to chrontel -l list so that it is explicitly passed to the linker. (Closed)

Created:
10 years, 3 months ago by raymes

Modified:
9 years, 7 months ago

Reviewers:
mdhayter

CC:
chromium-os-reviews_chromium.org

Base URL:
http://git.chromium.org/git/chrontel.git

Visibility:
Public.

Description

Added ext library to chrontel -l list so that it is explicitly passed to the linker. Without this, the package won't link with the gold linker. This is not a gold bug. Change-Id: Iaca7ecc74155e2ab0ac439c88437f502a38de448 BUG= TEST= Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=52027a0

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Makefile	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

raymes

Please review my fix and let me know if it should be backported somewhere.

10 years, 3 months ago (2010-09-15 22:40:34 UTC) #1

mdhayter

10 years, 3 months ago (2010-09-16 04:04:14 UTC) #2

LGTM. We are the host for this package, no need to upstream anywhere.

On 2010/09/15 22:40:34, raymes wrote:
> Please review my fix and let me know if it should be backported somewhere.

Expand Messages | Collapse Messages