Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 3443001: Forgot to add this to the commit enabling code coverage in the chrome_frame.g... (Closed)

Created:
10 years, 3 months ago by MAD
Modified:
9 years, 7 months ago
Reviewers:
robertshield, robert
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Forgot to add this to the commit enabling code coverage in the chrome_frame.gyp a little while back. BUG=0 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59408

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -0 lines) Patch
A chrome_frame/chrome_frame.croc View 1 1 chunk +121 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
MAD
It was sitting in the CL that I started to enable the code coverage on ...
10 years, 3 months ago (2010-09-14 14:26:27 UTC) #1
robertshield
http://codereview.chromium.org/3443001/diff/1/2 File chrome_frame/chrome_frame.croc (right): http://codereview.chromium.org/3443001/diff/1/2#newcode2 chrome_frame/chrome_frame.croc:2: # Crocodile config file for Chrome Frame. Is there ...
10 years, 3 months ago (2010-09-14 14:40:29 UTC) #2
MAD
Thanks! BYE MAD http://codereview.chromium.org/3443001/diff/1/2 File chrome_frame/chrome_frame.croc (right): http://codereview.chromium.org/3443001/diff/1/2#newcode2 chrome_frame/chrome_frame.croc:2: # Crocodile config file for Chrome ...
10 years, 3 months ago (2010-09-14 14:54:40 UTC) #3
robertshield
10 years, 3 months ago (2010-09-14 15:01:15 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698