Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: chrome/browser/download/save_package.cc

Issue 3442003: Regression fix: keep the download shelf visible when multiple sites are saved. (Closed)
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/save_package.cc
diff --git a/chrome/browser/download/save_package.cc b/chrome/browser/download/save_package.cc
index 42003faeefa3051c2cc39e13c8fcdf42c9803c81..9953a4cbc567e3db178c1c560686b7c49e1b3d19 100644
--- a/chrome/browser/download/save_package.cc
+++ b/chrome/browser/download/save_package.cc
@@ -301,14 +301,9 @@ SavePackage::~SavePackage() {
STLDeleteValues(&in_progress_items_);
STLDeleteValues(&saved_failed_items_);
- if (download_) {
- // We call this to remove the view from the shelf. It will invoke
- // DownloadManager::RemoveDownload, but since the fake DownloadItem is not
- // owned by DownloadManager, it will do nothing to our fake item.
- download_->Remove(false);
- delete download_;
- download_ = NULL;
- }
+ // The DownloadItem is owned by DownloadManager.
+ download_ = NULL;
+
file_manager_ = NULL;
// If there's an outstanding save dialog, make sure it doesn't call us back
« no previous file with comments | « chrome/browser/download/download_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698