Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 3441029: AP scan on correct wifi interfaces when dumping logs. (Closed)

Created:
10 years, 3 months ago by Daniel Kurtz
Modified:
9 years, 7 months ago
Reviewers:
Paul Stewart
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org
Visibility:
Public.

Description

AP scan on correct wifi interfaces when dumping logs. On some architectures (e.g. tegra2_seaboard), wifi interface does not enumerate as 'wlan0'. Therefore, first query flimflam for all known wifi interfaces (not just 'wlan0') before doing AP scan. Scanning on any potential additional interfaces is an added bonus where applicable. Change-Id: I9797acc98b36d8cb631e2a9afeb3bd16186e7b13 BUG=chromium-os:7000 TEST=Run a failing wifi test on x86-generic, "iw dev wlan0 scan" results should appear at end of test report; Run a failing wifi test on tegra2_seaboard, "iw dev eth0 scan" results should appear at end of test report. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c26804d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M server/site_wlan_connect.py View 1 chunk +20 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Daniel Kurtz
10 years, 3 months ago (2010-09-23 17:44:47 UTC) #1
Paul Stewart
LGTM. Please remember to set BUG=none before you push.
10 years, 3 months ago (2010-09-23 17:52:24 UTC) #2
Daniel Kurtz
10 years, 3 months ago (2010-09-23 18:42:21 UTC) #3
Bug 7000 created for this issue.

On 2010/09/23 17:52:24, Paul Stewart wrote:
> LGTM.  Please remember to set BUG=none before you push.

Powered by Google App Engine
This is Rietveld 408576698