Issue 344044: Clean up extension message port data in the renderer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 344044: Clean up extension message port data in the renderer. (Closed)

Created:
11 years, 1 month ago by Matt Perry

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Clean up extension message port data in the renderer. BUG=26262 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30884

Patch Set 1 #

Total comments: 2

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -3 lines)			Patch
	M	chrome/renderer/extensions/renderer_extension_bindings.cc	View		4 chunks	+19 lines, -3 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

lgtm Not sure about the below comment, just an idea. http://codereview.chromium.org/344044/diff/1/2 File chrome/renderer/extensions/renderer_extension_bindings.cc (right): http://codereview.chromium.org/344044/diff/1/2#newcode125 ...

11 years, 1 month ago (2009-10-31 19:21:22 UTC) #2

Matt Perry

11 years, 1 month ago (2009-11-03 00:39:36 UTC) #3

http://codereview.chromium.org/344044/diff/1/2
File chrome/renderer/extensions/renderer_extension_bindings.cc (right):

http://codereview.chromium.org/344044/diff/1/2#newcode125
Line 125: if (!HasPortData(port_id)) {
On 2009/10/31 19:21:22, Aaron Boodman wrote:
> Maybe we don't want to throw here? It seems nice that you can call close
whether
> or not the port is open.

Done.

Expand Messages | Collapse Messages