Issue 344043: Fixes regression introduced in fixing 19597. This change effectively...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 344043: Fixes regression introduced in fixing 19597. This change effectively... (Closed)

Created:
11 years, 1 month ago by sky

Modified:
9 years, 7 months ago

Reviewers:
jcampan

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixes regression introduced in fixing 19597. This change effectively reverts menu_button to what it was before the fix. This way 19597 is still fixed, and we don't have this crash. I'm working on a regression test for coverage of this, but I don't want to hold up anything with the fix. BUG=26279 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30651

Patch Set 1 #

Created: 11 years, 1 month ago

		Unified diffs	Side-by-side diffs	Stats (+6 lines, -2 lines)
	M	views/controls/button/menu_button.cc	View	1 chunk	+6 lines, -2 lines	0 comments

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages