Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: tools/valgrind/tsan/suppressions.txt

Issue 344040: Fix missing line in suppression; move the suppression to the more appropriate... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/valgrind/tsan/suppressions.txt
===================================================================
--- tools/valgrind/tsan/suppressions.txt (revision 30579)
+++ tools/valgrind/tsan/suppressions.txt (working copy)
@@ -75,6 +75,20 @@
fun:*browser_sync*BookmarkModelWorker*
}
+# The race happens during enumeration of ChromeThreads.
+# For each ChromeThread we check whether its message_loop()
+# equals MessageLoop::current().
+# The race can happen if one of the ChromeThreads is exiting.
+# This is benign since current thread can't exit while we
+# execute GetCurrentThreadIdentifier() and other message_loops
+# won't match the current one anyway.
+{
+ Benign race under ChromeThread::GetCurrentThreadIdentifier
+ ThreadSanitizer:Race
+ fun:*base*Thread*message_loop*
+ fun:*ChromeThread*GetCurrentThreadIdentifier*
+}
+
############################
# Real races in third_party
{
@@ -112,19 +126,6 @@
fun:*talk_base*MessageQueue*Get*
}
-# The race happens during enumeration of ChromeThreads.
-# For each ChromeThread we check whether its message_loop()
-# equals MessageLoop::current().
-# The race can happen if one of the ChromeThreads is exiting.
-# This is benign since current thread can't exit while we
-# execute GetCurrentThreadIdentifier() and other message_loops
-# won't match the current one anyway.
-{
- Benign race under ChromeThread::GetCurrentThreadIdentifier
- fun:*base*Thread*message_loop*
- fun:*ChromeThread*GetCurrentThreadIdentifier*
-}
-
############################
# Data races in tests
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698