Some new tab ui fixes.

chrome/browser/dom_ui/new_tab_ui.cc

Index: chrome/browser/dom_ui/new_tab_ui.cc
diff --git a/chrome/browser/dom_ui/new_tab_ui.cc b/chrome/browser/dom_ui/new_tab_ui.cc
index 07b8b126a34003c92f0847e492dcfcead193973e..37e6cfbced80cd65ddb8b3a1f49b6ac645ffbfc1 100644
--- a/chrome/browser/dom_ui/new_tab_ui.cc
+++ b/chrome/browser/dom_ui/new_tab_ui.cc
@@ -543,6 +543,7 @@ NewTabUI::NewTabUI(TabContents* contents)
   if (NewTabUI::FirstRunDisabled())
     NewTabHTMLSource::set_first_run(false);
 
+  InitializeCSSCaches();
   if (GetProfile()->IsOffTheRecord()) {
     incognito_ = true;
 
@@ -570,7 +571,6 @@ NewTabUI::NewTabUI(TabContents* contents)
 
     AddMessageHandler((new NewTabPageSetHomepageHandler())->Attach(this));
 
-    InitializeCSSCaches();
     NewTabHTMLSource* html_source = new NewTabHTMLSource(GetProfile());
     bool posted = ChromeThread::PostTask(
         ChromeThread::IO, FROM_HERE,
@@ -908,17 +908,24 @@ void NewTabUI::NewTabHTMLSource::InitFullHTML() {
         IDR_NEW_NEW_TAB_HTML);
   }
 
-  full_html_.assign(new_tab_html.data(), new_tab_html.size());
-
   // Inject the template data into the HTML so that it is available before any
   // layout is needed.
   std::string json_html;
   jstemplate_builder::AppendJsonHtml(&localized_strings, &json_html);
 
-  static const std::string template_data_placeholder =
-      "<!-- template data placeholder -->";
-  ReplaceFirstSubstringAfterOffset(&full_html_, 0, template_data_placeholder,
-      json_html);
+  static const base::StringPiece template_data_placeholder(
+      "<!-- template data placeholder -->");

[Evan Martin, 2009/10/29 22:27:28]

FWIW, if you want to get really anal about this, this calls strlen on the
string.  I think string::find() would work with a plain const char[].  Also
kFooBar for consts.

+  size_t pos = new_tab_html.find(template_data_placeholder);
 
+  if (pos != base::StringPiece::npos) {
+    full_html_.assign(new_tab_html.data(), pos);
+    full_html_.append(json_html);
+    size_t after_offset = pos + template_data_placeholder.size();
+    full_html_.append(new_tab_html.data() + after_offset,
+                      new_tab_html.size() - after_offset);
+  } else {
+    NOTREACHED();
+    full_html_.assign(new_tab_html.data(), new_tab_html.size());
+  }
   jstemplate_builder::AppendI18nTemplateProcessHtml(&full_html_);
 }