Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: net/socket/tcp_client_socket_unittest.cc

Issue 344026: Add LoadLog to ClientSocket::Connect(). (Closed)
Patch Set: Minor build fixups and fixed mac bug. Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/tcp_client_socket_pool_unittest.cc ('k') | net/socket/tcp_client_socket_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/tcp_client_socket_unittest.cc
diff --git a/net/socket/tcp_client_socket_unittest.cc b/net/socket/tcp_client_socket_unittest.cc
index 14d2305f8d05f54604c8396c541d29335fe37a8b..80b049696b7c29f275ff8fea68794aaa6efae9e2 100644
--- a/net/socket/tcp_client_socket_unittest.cc
+++ b/net/socket/tcp_client_socket_unittest.cc
@@ -9,6 +9,8 @@
#include "net/base/host_resolver.h"
#include "net/base/io_buffer.h"
#include "net/base/listen_socket.h"
+#include "net/base/load_log.h"
+#include "net/base/load_log_unittest.h"
#include "net/base/net_errors.h"
#include "net/base/test_completion_callback.h"
#include "net/base/winsock_init.h"
@@ -97,15 +99,22 @@ TEST_F(TCPClientSocketTest, Connect) {
TestCompletionCallback callback;
EXPECT_FALSE(sock_->IsConnected());
- int rv = sock_->Connect(&callback);
+ scoped_refptr<LoadLog> log(new LoadLog);
+ int rv = sock_->Connect(&callback, log);
+ EXPECT_TRUE(net::LogContains(
+ *log, 0, net::LoadLog::TYPE_TCP_CONNECT, net::LoadLog::PHASE_BEGIN));
if (rv != OK) {
ASSERT_EQ(rv, ERR_IO_PENDING);
+ EXPECT_FALSE(net::LogContains(
+ *log, -1, net::LoadLog::TYPE_TCP_CONNECT, net::LoadLog::PHASE_END));
rv = callback.WaitForResult();
EXPECT_EQ(rv, OK);
}
EXPECT_TRUE(sock_->IsConnected());
+ EXPECT_TRUE(net::LogContains(
+ *log, -1, net::LoadLog::TYPE_TCP_CONNECT, net::LoadLog::PHASE_END));
sock_->Disconnect();
EXPECT_FALSE(sock_->IsConnected());
@@ -117,7 +126,7 @@ TEST_F(TCPClientSocketTest, Connect) {
TEST_F(TCPClientSocketTest, Read) {
TestCompletionCallback callback;
- int rv = sock_->Connect(&callback);
+ int rv = sock_->Connect(&callback, NULL);
if (rv != OK) {
ASSERT_EQ(rv, ERR_IO_PENDING);
@@ -162,7 +171,7 @@ TEST_F(TCPClientSocketTest, Read) {
TEST_F(TCPClientSocketTest, Read_SmallChunks) {
TestCompletionCallback callback;
- int rv = sock_->Connect(&callback);
+ int rv = sock_->Connect(&callback, NULL);
if (rv != OK) {
ASSERT_EQ(rv, ERR_IO_PENDING);
@@ -207,7 +216,7 @@ TEST_F(TCPClientSocketTest, Read_SmallChunks) {
TEST_F(TCPClientSocketTest, Read_Interrupted) {
TestCompletionCallback callback;
- int rv = sock_->Connect(&callback);
+ int rv = sock_->Connect(&callback, NULL);
if (rv != OK) {
ASSERT_EQ(ERR_IO_PENDING, rv);
@@ -241,7 +250,7 @@ TEST_F(TCPClientSocketTest, Read_Interrupted) {
TEST_F(TCPClientSocketTest, DISABLED_FullDuplex_ReadFirst) {
TestCompletionCallback callback;
- int rv = sock_->Connect(&callback);
+ int rv = sock_->Connect(&callback, NULL);
if (rv != OK) {
ASSERT_EQ(rv, ERR_IO_PENDING);
@@ -283,7 +292,7 @@ TEST_F(TCPClientSocketTest, DISABLED_FullDuplex_ReadFirst) {
TEST_F(TCPClientSocketTest, DISABLED_FullDuplex_WriteFirst) {
TestCompletionCallback callback;
- int rv = sock_->Connect(&callback);
+ int rv = sock_->Connect(&callback, NULL);
if (rv != OK) {
ASSERT_EQ(ERR_IO_PENDING, rv);
« no previous file with comments | « net/socket/tcp_client_socket_pool_unittest.cc ('k') | net/socket/tcp_client_socket_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698