Issue 344011: * Fix new snapshot code on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 344011: * Fix new snapshot code on ARM. (Closed)

Created:
11 years, 1 month ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

* Fix new snapshot code on ARM. Committed: http://code.google.com/p/v8/source/detail?r=3161

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -8 lines)			Patch
M	src/arm/assembler-arm.h	View	1 chunk	+3 lines, -0 lines	1 comment	Download
M	src/arm/assembler-arm-inl.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/ia32/assembler-ia32.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/serialize.cc	View	3 chunks	+6 lines, -4 lines	0 comments	Download
M	src/x64/assembler-x64.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	test/cctest/cctest.status	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

11 years, 1 month ago (2009-10-28 11:55:16 UTC) #2

LGTM!

http://codereview.chromium.org/344011/diff/1/6
File src/arm/assembler-arm.h (right):

http://codereview.chromium.org/344011/diff/1/6#newcode440
Line 440: // Read/Modify the code target address in a constant pool entry.
Delete "Read/" as there is no read accessor.

Expand Messages | Collapse Messages