 Chromium Code Reviews
 Chromium Code Reviews Issue 344010:
  Add fast check for NaN in NumberCompare slow case.  (Closed) 
  Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
    
  
    Issue 344010:
  Add fast check for NaN in NumberCompare slow case.  (Closed) 
  Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/| Index: src/runtime.js | 
| =================================================================== | 
| --- src/runtime.js (revision 3152) | 
| +++ src/runtime.js (working copy) | 
| @@ -128,7 +128,10 @@ | 
| if (IS_STRING(a) && IS_STRING(b)) { | 
| return %StringCompare(a, b); | 
| } else { | 
| - return %NumberCompare(%ToNumber(a), %ToNumber(b), ncr); | 
| + var a_number = %ToNumber(a); | 
| + var b_number = %ToNumber(b); | 
| + if (NUMBER_IS_NAN(a_number) || NUMBER_IS_NAN(b_number)) return ncr; | 
| + return %NumberCompare(a_number, b_number, ncr); | 
| } | 
| } |