Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: chrome/browser/cocoa/chrome_event_processing_window.mm

Issue 344008: Implemented most of HtmlDialogWindowController, which is a Cocoa port (Closed)
Patch Set: Added TODOs. Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/chrome_event_processing_window.mm
diff --git a/chrome/browser/cocoa/chrome_event_processing_window.mm b/chrome/browser/cocoa/chrome_event_processing_window.mm
index 31700121e0d72a07caec81efc14a0c30b298260c..e70113ab0b40ff203d9230386e702c23b05c0bfb 100644
--- a/chrome/browser/cocoa/chrome_event_processing_window.mm
+++ b/chrome/browser/cocoa/chrome_event_processing_window.mm
@@ -5,7 +5,7 @@
#import "chrome/browser/cocoa/chrome_event_processing_window.h"
#include "base/logging.h"
-#import "chrome/browser/cocoa/browser_window_controller.h"
+#import "chrome/browser/cocoa/browser_command_executor.h"
#import "chrome/browser/cocoa/browser_frame_view.h"
#import "chrome/browser/cocoa/tab_strip_controller.h"
#import "chrome/browser/renderer_host/render_widget_host_view_mac.h"
@@ -28,14 +28,12 @@ typedef int (*KeyToCommandMapper)(bool, bool, bool, bool, int);
int cmdNum = commandForKeyboardShortcut(cmdKey, shiftKey, cntrlKey, optKey,
keyCode);
- BrowserWindowController* controller =
- (BrowserWindowController*)[self delegate];
- // A bit of sanity.
- DCHECK([controller isKindOfClass:[BrowserWindowController class]]);
- DCHECK([controller respondsToSelector:@selector(executeCommand:)]);
-
if (cmdNum != -1) {
- [controller executeCommand:cmdNum];
+ id executor = [self delegate];
+ // A bit of sanity.
+ DCHECK([executor conformsToProtocol:@protocol(BrowserCommandExecutor)]);
+ DCHECK([executor respondsToSelector:@selector(executeCommand:)]);
+ [executor executeCommand:cmdNum];
return YES;
}
return NO;
« no previous file with comments | « chrome/browser/cocoa/browser_window_controller.h ('k') | chrome/browser/cocoa/chrome_event_processing_window_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698