Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 344004: Make 'gclient update' and 'gclient status' quieter by default - they don't... (Closed)

Created:
11 years, 1 month ago by Dirk Pranke
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Make 'gclient update' and 'gclient status' quieter by default - they don't print messages unless the underlying commands actually generate output. This is a more conservative version of r28271. BUG=none TEST=none R=maruel Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30296

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M gclient.py View 4 chunks +0 lines, -4 lines 0 comments Download
M gclient_scm.py View 8 chunks +8 lines, -7 lines 0 comments Download
M gclient_utils.py View 1 chunk +4 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Dirk Pranke
Hi Marc-Antoine, This is a more conservative attempt to make things quieter by default. It ...
11 years, 1 month ago (2009-10-27 22:25:11 UTC) #1
M-A Ruel
lgtm with one change. http://codereview.chromium.org/344004/diff/1/3 File gclient_utils.py (right): http://codereview.chromium.org/344004/diff/1/3#newcode217 Line 217: if not print_messages: Move ...
11 years, 1 month ago (2009-10-27 23:31:13 UTC) #2
Dirk Pranke
http://codereview.chromium.org/344004/diff/1/3 File gclient_utils.py (right): http://codereview.chromium.org/344004/diff/1/3#newcode217 Line 217: if not print_messages: On 2009/10/27 23:31:13, Marc-Antoine Ruel ...
11 years, 1 month ago (2009-10-27 23:44:30 UTC) #3
M-A Ruel
11 years, 1 month ago (2009-10-27 23:59:02 UTC) #4
On 2009/10/27 23:44:30, dpranke wrote:
> http://codereview.chromium.org/344004/diff/1/3
> File gclient_utils.py (right):
> 
> http://codereview.chromium.org/344004/diff/1/3#newcode217
> Line 217: if not print_messages:
> On 2009/10/27 23:31:13, Marc-Antoine Ruel wrote:
> > Move this inside the print_stdout. You don't want to print this line when
> > print_stdout is False.
> 
> Are you sure? In the old version we would've printed the line regardless of
the
> value of print_stdout. What's the difference here?

You are changing the behavior when print_message=False, print_stdout=False. This
is used to grep command outputs like svn status.

Powered by Google App Engine
This is Rietveld 408576698