Issue 3440033: manifest layouts: add cros_boot_mode to platform/

Issue 3440033: manifest layouts: add cros_boot_mode to platform/ (Closed)

Created:
10 years, 2 months ago by Will Drewry

Modified:
9 years, 7 months ago

Reviewers:
Mandeep Singh Baines, anush

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://gitrw.chromium.org/manifest

Visibility:
Public.

Description

manifest layouts: add cros_boot_mode to platform/ Add cros_boot_image to the directory tree. TEST=added, then syncd. BUG=chromium-os:824, chromium-os:6864

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	minilayout.xml	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	oldlayout.xml	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

anush

LGTM On Mon, Sep 27, 2010 at 9:39 PM, <wad@chromium.org> wrote: > Reviewers: anush, Mandeep ...

10 years, 2 months ago (2010-09-27 23:01:04 UTC) #2

Mandeep Singh Baines

wad@chromium.org (wad@chromium.org) wrote: > Reviewers: anush, Mandeep Singh Baines, > > Description: > manifest layouts: ...

10 years, 2 months ago (2010-09-28 00:10:45 UTC) #3

Will Drewry

It's in the commented out section. I just included it in the comment to make ...

10 years, 2 months ago (2010-09-28 00:40:58 UTC) #4

It's in the commented out section.  I just included it in the comment
to make it match everything else.  I didn't know if the comment was
magically munged, etc.  I know we have some very "lax" xml parsing
happening :)

On Mon, Sep 27, 2010 at 7:06 PM, Mandeep Singh Baines <msb@chromium.org> wrote:
> wad@chromium.org (wad@chromium.org) wrote:
>> Reviewers: anush, Mandeep Singh Baines,
>>
>> Description:
>> manifest layouts: add cros_boot_mode to platform/
>>
>> Add cros_boot_image to the directory tree.
>>
>> TEST=added, then syncd.
>> BUG=chromium-os:824,chromium-os:6864
>>
>> Please review this at http://codereview.chromium.org/3440033/show
>>
>> SVN Base: ssh://gitrw.chromium.org/manifest
>>
>> Affected files:
>>   M minilayout.xml
>>   M oldlayout.xml
>>
>>
>> Index: minilayout.xml
>> diff --git a/minilayout.xml b/minilayout.xml
>> index
33f3dcc131ba2b7cc32ba0e6e9dda9e7088a7ba2..30b29b378c7b66e3b5620ba7ef684eac7e570d57
>> 100644
>> --- a/minilayout.xml
>> +++ b/minilayout.xml
>> @@ -34,6 +34,7 @@
>>    <project path="src/platform/crash-reporter" name="crash-reporter" />
>>    <project path="src/platform/cromo" name="cromo" />
>>    <project path="src/platform/cros" name="cros" />
>> +  <project path="src/platform/cros_boot_mode" name="cros_boot_mode" />
>
> Why does this need to be in the minilayout?
>
>>    <project path="src/platform/cryptohome" name="cryptohome" />
>>    <project path="src/platform/dump-syms" name="dump-syms" />
>>    <project path="src/platform/entd" name="entd" />
>> Index: oldlayout.xml
>> diff --git a/oldlayout.xml b/oldlayout.xml
>> index
c5767a90a31a8a623b8e647a8e1677f35b3cf1f3..e354021709a90ce1a10268389c2416aa50d83794
>> 100644
>> --- a/oldlayout.xml
>> +++ b/oldlayout.xml
>> @@ -18,6 +18,7 @@
>>    <project path="src/platform/crash-reporter" name="crash-reporter" />
>>    <project path="src/platform/cromo" name="cromo" />
>>    <project path="src/platform/cros" name="cros" />
>> +  <project path="src/platform/cros_boot_mode" name="cros_boot_mode" />
>>    <project path="src/platform/cryptohome" name="cryptohome" />
>>    <project path="src/platform/dev" name="dev-util" />
>>    <project path="src/platform/dump-syms" name="dump-syms" />
>>
>>
>

msb

10 years, 2 months ago (2010-09-28 01:43:38 UTC) #5

LGTM

Will Drewry (wad@chromium.org) wrote:
> It's in the commented out section.  I just included it in the comment

Ah.

> to make it match everything else.  I didn't know if the comment was
> magically munged, etc.  I know we have some very "lax" xml parsing
> happening :)
> 

Yeah, changed the code to use python's xml.etree parsing library so the
commented section isn't really needed any more. I'll send a CL to remove it.

> On Mon, Sep 27, 2010 at 7:06 PM, Mandeep Singh Baines <msb@chromium.org>
wrote:
> > wad@chromium.org (wad@chromium.org) wrote:
> >> Reviewers: anush, Mandeep Singh Baines,
> >>
> >> Description:
> >> manifest layouts: add cros_boot_mode to platform/
> >>
> >> Add cros_boot_image to the directory tree.
> >>
> >> TEST=added, then syncd.
> >> BUG=chromium-os:824,chromium-os:6864
> >>
> >> Please review this at http://codereview.chromium.org/3440033/show
> >>
> >> SVN Base: ssh://gitrw.chromium.org/manifest
> >>
> >> Affected files:
> >>   M minilayout.xml
> >>   M oldlayout.xml
> >>
> >>
> >> Index: minilayout.xml
> >> diff --git a/minilayout.xml b/minilayout.xml
> >> index
33f3dcc131ba2b7cc32ba0e6e9dda9e7088a7ba2..30b29b378c7b66e3b5620ba7ef684eac7e570d57
> >> 100644
> >> --- a/minilayout.xml
> >> +++ b/minilayout.xml
> >> @@ -34,6 +34,7 @@
> >>    <project path="src/platform/crash-reporter" name="crash-reporter" />
> >>    <project path="src/platform/cromo" name="cromo" />
> >>    <project path="src/platform/cros" name="cros" />
> >> +  <project path="src/platform/cros_boot_mode" name="cros_boot_mode" />
> >
> > Why does this need to be in the minilayout?
> >
> >>    <project path="src/platform/cryptohome" name="cryptohome" />
> >>    <project path="src/platform/dump-syms" name="dump-syms" />
> >>    <project path="src/platform/entd" name="entd" />
> >> Index: oldlayout.xml
> >> diff --git a/oldlayout.xml b/oldlayout.xml
> >> index
c5767a90a31a8a623b8e647a8e1677f35b3cf1f3..e354021709a90ce1a10268389c2416aa50d83794
> >> 100644
> >> --- a/oldlayout.xml
> >> +++ b/oldlayout.xml
> >> @@ -18,6 +18,7 @@
> >>    <project path="src/platform/crash-reporter" name="crash-reporter" />
> >>    <project path="src/platform/cromo" name="cromo" />
> >>    <project path="src/platform/cros" name="cros" />
> >> +  <project path="src/platform/cros_boot_mode" name="cros_boot_mode" />
> >>    <project path="src/platform/cryptohome" name="cryptohome" />
> >>    <project path="src/platform/dev" name="dev-util" />
> >>    <project path="src/platform/dump-syms" name="dump-syms" />
> >>
> >>
> >

Expand Messages | Collapse Messages