Issue 3440032: Don't treat ';' as an authority terminator when parsing a potential URL. Thi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3440032: Don't treat ';' as an authority terminator when parsing a potential URL. Thi... (Closed)

Created:
10 years, 2 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Don't treat ';' as an authority terminator when parsing a potential URL. This was making the omnibox believe that "tl;dr" was a URL with "tl" as a host and ";dr" as a path, confusing it. BUG=56967 TEST=Covered by unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60726

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/autocomplete/autocomplete_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

10 years, 2 months ago (2010-09-27 21:18:10 UTC) #2

LGTM

On Mon, Sep 27, 2010 at 2:07 PM,  <pkasting@chromium.org> wrote:
> Reviewers: brettw,
>
> Description:
> Don't treat ';' as an authority terminator when parsing a potential URL.
>  This
> was making the omnibox believe that "tl;dr" was a URL with "tl" as a host
> and
> ";dr" as a path, confusing it.
>
> BUG=56967
> TEST=Covered by unittests
>
> Please review this at http://codereview.chromium.org/3440032/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     DEPS
>  M     chrome/browser/autocomplete/autocomplete_unittest.cc
>
>
> Index: DEPS
> ===================================================================
> --- DEPS        (revision 60381)
> +++ DEPS        (working copy)
> @@ -20,7 +20,7 @@
>     "/trunk/deps/support@20411",
>
>   "src/googleurl":
> -    (Var("googlecode_url") % "google-url") + "/trunk@146",
> +    (Var("googlecode_url") % "google-url") + "/trunk@147",
>
>   "src/seccompsandbox":
>     "http://seccompsandbox.googlecode.com/svn/trunk@119",
> Index: chrome/browser/autocomplete/autocomplete_unittest.cc
> ===================================================================
> --- chrome/browser/autocomplete/autocomplete_unittest.cc        (revision
> 60381)
> +++ chrome/browser/autocomplete/autocomplete_unittest.cc        (working
> copy)
> @@ -217,6 +217,7 @@
>     { L"foo.com", AutocompleteInput::URL },
>     { L"-.com", AutocompleteInput::UNKNOWN },
>     { L"foo/bar", AutocompleteInput::URL },
> +    { L"foo;bar", AutocompleteInput::QUERY },
>     { L"foo/bar baz", AutocompleteInput::UNKNOWN },
>     { L"foo bar.com", AutocompleteInput::QUERY },
>     { L"foo bar", AutocompleteInput::QUERY },
>
>
>

Expand Messages | Collapse Messages