Issue 3440026: Fix mouse event handling in Chromoting plugin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3440026: Fix mouse event handling in Chromoting plugin. (Closed)

Created:
10 years, 3 months ago by garykac

Modified:
9 years, 6 months ago

Reviewers:
brettw, awong

CC:
chromium-reviews, Sergey Ulanov, dmac, garykac, Alpha Left Google

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Fix mouse event handling in Chromoting plugin. Revision 60257 changed the Pepper PluginInstance to call HandleInputEvent instead of HandleEvent. Since HandleEvent was virtual in the subclass, this was not caught by the compiler. Here's where a proper 'override' keyword in C++ would've been nice. BUG=none TEST=verify mouse works Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60467

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -3 lines)			Patch
M	remoting/client/plugin/chromoting_instance.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/client/plugin/chromoting_instance.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/client/plugin/pepper_input_handler.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

10 years, 3 months ago (2010-09-23 23:45:25 UTC) #3

LGTM. Note that char events currently crash, Jam has a fix.

Expand Messages | Collapse Messages