Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Issue 3440008: Disables "Bookmark all tabs" item in the tab contex menu. (Closed)

Created:
10 years, 3 months ago by altimofeev
Modified:
9 years, 7 months ago
Reviewers:
whywhat, Peter Kasting
CC:
chromium-reviews, ben+cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Disables "Bookmark all tabs" item in the tab contex menu. BUG=chromium-os:6028 TEST=Go BWSI session, open at least 2 tabs, notice item "Bookmark all tabs" is disabled. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60167

Patch Set 1 #

Patch Set 2 : review iteration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/tabs/tab_strip_model.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
altimofeev
Please review.
10 years, 3 months ago (2010-09-17 00:14:55 UTC) #1
whywhat
LGTM
10 years, 3 months ago (2010-09-17 04:21:56 UTC) #2
Peter Kasting
Why is the #ifdef present? We should respect the flag on all platforms.
10 years, 3 months ago (2010-09-17 18:43:42 UTC) #3
whywhat
On 2010/09/17 18:43:42, Peter Kasting wrote: > Why is the #ifdef present? We should respect ...
10 years, 3 months ago (2010-09-17 20:09:45 UTC) #4
altimofeev
> Why is the #ifdef present? We should respect the flag on all platforms. Fixed.
10 years, 3 months ago (2010-09-17 20:33:15 UTC) #5
whywhat
10 years, 3 months ago (2010-09-21 12:17:25 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698