Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4061)

Unified Diff: chrome/browser/bookmarks/bookmark_html_writer_unittest.cc

Issue 3439028: Fix unittest to not use an invalid GURL, as the underlying bookmarks APIs exp... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/bookmark_html_writer_unittest.cc
===================================================================
--- chrome/browser/bookmarks/bookmark_html_writer_unittest.cc (revision 60733)
+++ chrome/browser/bookmarks/bookmark_html_writer_unittest.cc (working copy)
@@ -141,7 +141,7 @@
// Tests bookmark_html_writer by populating a BookmarkModel, writing it out by
// way of bookmark_html_writer, then using the importer to read it back in.
-TEST_F(BookmarkHTMLWriterTest, DISABLED_Test) {
+TEST_F(BookmarkHTMLWriterTest, Test) {
MessageLoop message_loop;
ChromeThread fake_ui_thread(ChromeThread::UI, &message_loop);
ChromeThread fake_file_thread(ChromeThread::FILE, &message_loop);
@@ -186,7 +186,7 @@
GURL url1_favicon("http://url1/icon.ico");
GURL url2("http://url2");
GURL url3("http://url3");
- GURL url4("http://\"&;\"");
+ GURL url4("javascript:alert(\"Hello!\");");
base::Time t1(base::Time::Now());
base::Time t2(t1 + base::TimeDelta::FromHours(1));
base::Time t3(t1 + base::TimeDelta::FromHours(1));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698