Adding automation for some P2 tests in two client live bookmarks sync...

Adding automation for some P2 tests in two client live bookmarks sync

1. Single Client Duplicate Bookmarks With Same URL
2. Single Client Twice Renaming Bookmark Name
3. Single Client Twice Renaming Bookmark URL

Patch from Sunand Tullimalli <sunandt@chromium.org>;.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60698

[Raghu Simha, 2010-09-22 06:10:04]

LGTM, pending a minor change I've suggested, and a green trybot run.

http://codereview.chromium.org/3439015/diff/1/2
File chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc (right):

http://codereview.chromium.org/3439015/diff/1/2#newcode2362
chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc:2362: 
It's a good idea to annotate each test with the ID of the Testscribe test case
you're automating.

[sunandt, 2010-09-22 16:44:49]

Added TS ids

http://codereview.chromium.org/3439015/diff/1/2
File chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc (right):

http://codereview.chromium.org/3439015/diff/1/2#newcode2362
chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc:2362: 
On 2010/09/22 06:10:04, rsimha wrote:
> It's a good idea to annotate each test with the ID of the Testscribe test case
> you're automating.

Done.

[anantha, 2010-09-22 17:17:01]

LGTM. Please fix the following:

http://codereview.chromium.org/3439015/diff/5001/6001
File chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc (right):

http://codereview.chromium.org/3439015/diff/5001/6001#newcode2363
chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc:2363: // Test
Scribe ID - 370639
Along with TS ids, a one line summary of what that test is doing will be very
helpful.

http://codereview.chromium.org/3439015/diff/5001/6001#newcode2374
chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc:2374:
verifier->ExpectMatch(profile0_bookmark_model);
Lines 2374 and 2375: Why do we need these verifiers here? If they are not
needed, delete them.

[sunandt, 2010-09-22 22:12:18]

Modified things that Anantha suggested.

http://codereview.chromium.org/3439015/diff/5001/6001
File chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc (right):

http://codereview.chromium.org/3439015/diff/5001/6001#newcode2363
chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc:2363: // Test
Scribe ID - 370639
On 2010/09/22 17:17:01, anantha wrote:
> Along with TS ids, a one line summary of what that test is doing will be very
> helpful.
> 

Done.

http://codereview.chromium.org/3439015/diff/5001/6001#newcode2374
chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc:2374:
verifier->ExpectMatch(profile0_bookmark_model);
On 2010/09/22 17:17:01, anantha wrote:
> Lines 2374 and 2375: Why do we need these verifiers here? If they are not
> needed, delete them.

These verifications are done to ensure that profile0 and profile1 are in same
state after sync setup. So to make more sense, I've moved these up to verify
after we create the bookmark model for profile0 and profile1.

[Raghu Simha, 2010-09-22 22:30:07]

http://codereview.chromium.org/3439015/diff/10001/11001
File chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc (right):

http://codereview.chromium.org/3439015/diff/10001/11001#newcode2363
chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc:2363: // Test
Scribe ID - 370639 - Add bookmarks with different name and same URL
nit: Period required after comment.

http://codereview.chromium.org/3439015/diff/10001/11001#newcode2392
chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc:2392: // Test
Scribe ID - 371818 - Renaming the same bookmark name twice
nit: Period required after comment.

http://codereview.chromium.org/3439015/diff/10001/11001#newcode2427
chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc:2427: // Test
Scribe ID - 371823 - Renaming the same bookmark URL twice
nit: Period required after comment.

[sunandt, 2010-09-22 22:39:07]

On 2010/09/22 22:30:07, rsimha wrote:
> http://codereview.chromium.org/3439015/diff/10001/11001
> File chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc (right):
> 
> http://codereview.chromium.org/3439015/diff/10001/11001#newcode2363
> chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc:2363: // Test
> Scribe ID - 370639 - Add bookmarks with different name and same URL
> nit: Period required after comment.
> 
> http://codereview.chromium.org/3439015/diff/10001/11001#newcode2392
> chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc:2392: // Test
> Scribe ID - 371818 - Renaming the same bookmark name twice
> nit: Period required after comment.
> 
> http://codereview.chromium.org/3439015/diff/10001/11001#newcode2427
> chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc:2427: // Test
> Scribe ID - 371823 - Renaming the same bookmark URL twice
> nit: Period required after comment.

Done.

[Raghu Simha, 2010-09-24 20:37:34]

http://codereview.chromium.org/3439015/diff/14001/15001
File chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc (right):

http://codereview.chromium.org/3439015/diff/14001/15001#newcode2184
chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc:2184: // Test
Scribe ID - 373509 - Merge moderatly complex bookmark models.
nit: "moderately"

[sunandt, 2010-09-24 23:53:46]

Fixed compile errors occurred on trybots.

http://codereview.chromium.org/3439015/diff/14001/15001
File chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc (right):

http://codereview.chromium.org/3439015/diff/14001/15001#newcode2184
chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc:2184: // Test
Scribe ID - 373509 - Merge moderatly complex bookmark models.
On 2010/09/24 20:37:34, rsimha wrote:
> nit: "moderately"

Done.

[Raghu Simha, 2010-09-27 20:18:24]

All trybot runs green. Sync tests passed -- see
http://build.chromium.org/buildbot/try-server/builders/linux_sync/builds/133.

[sunandt, 2010-09-27 20:51:31]

Thanks for checking the patch Raghu.

On 2010/09/27 20:18:24, rsimha wrote:
> All trybot runs green. Sync tests passed -- see
> http://build.chromium.org/buildbot/try-server/builders/linux_sync/builds/133.