dbus_service.cc - Issue 3437019: [update_engine] handle NULL returns from strdup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dbus_service.cc

Issue 3437019: [update_engine] handle NULL returns from strdup (Closed) Base URL: http://git.chromium.org/git/update_engine.git

Patch Set: fixed nits. Pushing... Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dbus_service.cc

diff --git a/dbus_service.cc b/dbus_service.cc

index d5bf13f5243736acf5f18f23f36719f045ad7aef..677dbc85990469fdb8e1a293bd833b1acf5268ea 100644

--- a/dbus_service.cc

+++ b/dbus_service.cc

@@ -77,6 +77,10 @@ gboolean update_engine_service_get_status(UpdateEngineService* self,

*current_operation = strdup(current_op.c_str());

*new_version = strdup(new_version_str.c_str());

+ if (!(*current_operation && *new_version)) {

+ *error = NULL;

+ return FALSE;

+ }

return TRUE;

}

« no previous file with comments | « no previous file | subprocess.cc » ('j') | no next file with comments »