Issue 3437016: Add better handling of a TPM clear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3437016: Add better handling of a TPM clear. (Closed)

Created:
10 years, 3 months ago by fes

Modified:
9 years, 7 months ago

Reviewers:
Chris Masone

CC:
chromium-os-reviews_chromium.org

Base URL:
http://git.chromium.org/git/tpm_init.git

Visibility:
Public.

Description

Add better handling of a TPM clear. This adds a callback so that the user of TpmInit can receive a notification when the TPM initialization finishes. Change-Id: I719810052e02536d54913950d0b9f053e6e3a01c BUG=6883 TEST=(see change in cryptohome) Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ddb6a47

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unnecessary include. #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -24 lines)			Patch
M	tpm.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tpm.cc	View	1	3 chunks	+10 lines, -2 lines	0 comments	Download
M	tpm_init.h	View		2 chunks	+10 lines, -1 line	0 comments	Download
M	tpm_init.cc	View		4 chunks	+32 lines, -20 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Chris Masone

lgtm w/nit http://codereview.chromium.org/3437016/diff/1/2 File tpm.cc (right): http://codereview.chromium.org/3437016/diff/1/2#newcode11 tpm.cc:11: #include <base/string_util.h> why add this?

10 years, 3 months ago (2010-09-22 21:57:28 UTC) #2

fes

Done, PTAL http://codereview.chromium.org/3437016/diff/1/2 File tpm.cc (right): http://codereview.chromium.org/3437016/diff/1/2#newcode11 tpm.cc:11: #include <base/string_util.h> On 2010/09/22 21:57:28, Chris Masone ...

10 years, 3 months ago (2010-09-22 22:05:28 UTC) #3

Chris Masone

10 years, 3 months ago (2010-09-23 18:11:57 UTC) #4

LGTM

On 2010/09/22 22:05:28, fes wrote:
> Done, PTAL
> 
> http://codereview.chromium.org/3437016/diff/1/2
> File tpm.cc (right):
> 
> http://codereview.chromium.org/3437016/diff/1/2#newcode11
> tpm.cc:11: #include <base/string_util.h>
> On 2010/09/22 21:57:28, Chris Masone wrote:
> > why add this?
> 
> Ouch, good catch.  I added this while testing, but didn't take it out.  Thanks
> for noticing, fixed.

Expand Messages | Collapse Messages