Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 3437008: Merge 59684 - Mac: Fix concurrent access on a non-threadsafe data structure.... (Closed)

Created:
10 years, 3 months ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, pam+watch_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Merge 59684 - Mac: Fix concurrent access on a non-threadsafe data structure. Also remove a call to cocoa from the non-ui thread. DrawAcceleratedSurfaceInstance is called on the display link thread. plugin_views_ can be written to from the main thread. Since the map is only used to get the view's size, pass in the size right away. There's another problem like this in plugin_container_manager_, which also has a map that is accessed from two threads. I will address this in a follow-up CL. BUG=52491 TEST=none Review URL: http://codereview.chromium.org/3431011 TBR=thakis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59894

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -12 lines) Patch
M chrome/browser/renderer_host/render_widget_host_view_mac.h View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.mm View 7 chunks +27 lines, -10 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nico
10 years, 3 months ago (2010-09-18 04:24:01 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698