[Chrome OS] Refactor Canonicalize() method into base class to prepare for new Authenticator subclass

chrome/browser/chromeos/login/authenticator.h

Index: chrome/browser/chromeos/login/authenticator.h
diff --git a/chrome/browser/chromeos/login/authenticator.h b/chrome/browser/chromeos/login/authenticator.h
index 613b7faa490be62f39ca359b80733d173b1f5fa2..b19e2935efa23fe61cb65098baaab997aa9d51f6 100644
--- a/chrome/browser/chromeos/login/authenticator.h
+++ b/chrome/browser/chromeos/login/authenticator.h
@@ -8,7 +8,6 @@
 
 #include "base/basictypes.h"
 #include "base/ref_counted.h"
-#include "chrome/browser/chrome_thread.h"
 #include "chrome/browser/chromeos/login/login_status_consumer.h"
 #include "chrome/common/net/gaia/gaia_auth_consumer.h"
 
@@ -24,10 +23,8 @@ namespace chromeos {
 // consumer_->OnPasswordChangeDetected() on the UI thread.
 class Authenticator : public base::RefCountedThreadSafe<Authenticator> {
  public:
-  explicit Authenticator(LoginStatusConsumer* consumer)
-      : consumer_(consumer) {
-  }
-  virtual ~Authenticator() {}
+  explicit Authenticator(LoginStatusConsumer* consumer);
+  virtual ~Authenticator();
 
   // Given a |username| and |password|, this method attempts to authenticate
   // to login.
@@ -74,6 +71,12 @@ class Authenticator : public base::RefCountedThreadSafe<Authenticator> {
   virtual void ResyncEncryptedData(
       const GaiaAuthConsumer::ClientLoginResult& credentials) = 0;
 
+  // Perform basic canonicalization of |email_address|, taking into account
+  // that gmail does not consider '.' or caps inside a username to matter.
+  // For example, c.masone@gmail.com == cMaSone@gmail.com, per
+  // http://mail.google.com/support/bin/answer.py?hl=en&ctx=mail&answer=10313#

[Zachary Kuznia, 2010/09/28 04:15:03]

Could you update this comment to note that anything after a '+' is also ignored?

[Chris Masone, 2010/09/28 04:33:17]

Done.

+  static std::string Canonicalize(const std::string& email_address);
+
  protected:
   LoginStatusConsumer* consumer_;