Issue 3436031: [Chrome OS] Refactor Canonicalize() method into base class to prepare for new Authenticator subclass

Issue 3436031: [Chrome OS] Refactor Canonicalize() method into base class to prepare for new Authenticator subclass (Closed)

Created:
10 years, 3 months ago by Chris Masone

Modified:
9 years, 7 months ago

Reviewers:
Zachary Kuznia

CC:
chromium-reviews, Paweł Hajdan Jr., nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

[Chrome OS] Refactor Canonicalize() method into base class to prepare for new Authenticator subclass BUG=chromium-os:4929 TEST=unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60752

Patch Set 2 : Add missing files #

Patch Set 3 : aaaaand fix one more header #

Total comments: 2

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+110 lines, -76 lines)			Patch
M	chrome/browser/chromeos/login/authenticator.h	View	3 chunks	+8 lines, -5 lines	2 comments	Download
A	chrome/browser/chromeos/login/authenticator.cc	View	1 chunk	+37 lines, -0 lines	0 comments	Download
A	chrome/browser/chromeos/login/authenticator_unittest.cc	View	1 chunk	+56 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/google_authenticator.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/login/google_authenticator.cc	View	2 chunks	+0 lines, -16 lines	0 comments	Download
M	chrome/browser/chromeos/login/google_authenticator_unittest.cc	View	3 chunks	+2 lines, -46 lines	0 comments	Download
M	chrome/browser/chromeos/login/mock_authenticator.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/screen_locker.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_image_downloader.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Zachary Kuznia

LGTM with updated comment. http://codereview.chromium.org/3436031/diff/6001/7002 File chrome/browser/chromeos/login/authenticator.h (right): http://codereview.chromium.org/3436031/diff/6001/7002#newcode77 chrome/browser/chromeos/login/authenticator.h:77: // http://mail.google.com/support/bin/answer.py?hl=en&ctx=mail&answer=10313# Could you update ...

10 years, 2 months ago (2010-09-28 04:15:03 UTC) #2

Chris Masone

10 years, 2 months ago (2010-09-28 04:33:17 UTC) #3

and committing...

http://codereview.chromium.org/3436031/diff/6001/7002
File chrome/browser/chromeos/login/authenticator.h (right):

http://codereview.chromium.org/3436031/diff/6001/7002#newcode77
chrome/browser/chromeos/login/authenticator.h:77: //
http://mail.google.com/support/bin/answer.py?hl=en&ctx=mail&answer=10313#
On 2010/09/28 04:15:03, Zachary Kuznia wrote:
> Could you update this comment to note that anything after a '+' is also
ignored?

Done.

Expand Messages | Collapse Messages