crash_reporter.cc - Issue 3436029: crash-reporter: Send OS version at time of crash and related improvements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: crash_reporter.cc

Issue 3436029: crash-reporter: Send OS version at time of crash and related improvements (Closed) Base URL: http://git.chromium.org/git/crash-reporter.git

Patch Set: respond to petkov review Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: crash_reporter.cc

diff --git a/crash_reporter.cc b/crash_reporter.cc

index b57bfc40bffca3fda79a53104326b4e539360709..d8583869804278bd492e82a63171bd024d3054e5 100644

--- a/crash_reporter.cc

+++ b/crash_reporter.cc

@@ -43,9 +43,7 @@ static MetricsLibrary s_metrics_lib;

static SystemLoggingImpl s_system_log;

static bool IsFeedbackAllowed() {

- // Once crosbug.com/5814 is fixed, call the is opted in function

- // here.

- return true;

+ return s_metrics_lib.AreMetricsEnabled();

}

static bool TouchFile(const FilePath &file_path) {

« no previous file with comments | « crash_collector_test.cc ('k') | crash_sender » ('j') | no next file with comments »