crash-reporter: Send OS version at time of crash and related improvements

kernel_collector_test.cc

 // Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <unistd.h>
 
 #include "base/file_util.h"
 #include "base/string_util.h"
 #include "crash-reporter/kernel_collector.h"
 #include "crash-reporter/system_logging_mock.h"
@@ skipping 77 matching lines @@
   std::string dump;
   ASSERT_FALSE(file_util::PathExists(test_kcrash_));
   WriteStringToFile(test_kcrash_, "something");
   ASSERT_TRUE(collector_.LoadPreservedDump(&dump));
   ASSERT_EQ("something", dump);
   ASSERT_TRUE(collector_.ClearPreservedDump());
   ASSERT_TRUE(collector_.LoadPreservedDump(&dump));
   ASSERT_EQ(KernelCollector::kClearingSequence, dump);
 }
 
-TEST_F(KernelCollectorTest, GetKernelCrashPath) {
-  FilePath root("/var/spool/crash");
-  struct tm tm = {0};
-  tm.tm_sec = 15;
-  tm.tm_min = 50;
-  tm.tm_hour = 13;
-  tm.tm_mday = 23;
-  tm.tm_mon = 4;
-  tm.tm_year = 110;
-  tm.tm_isdst = -1;
-  FilePath path = collector_.GetKernelCrashPath(root, mktime(&tm));
-  ASSERT_EQ("/var/spool/crash/kernel.20100523.135015.0.kcrash",
-            path.value());
-}
-
 TEST_F(KernelCollectorTest, CollectPreservedFileMissing) {
   ASSERT_FALSE(collector_.Collect());
   ASSERT_NE(logging_.log().find("Unable to read test/kcrash"),
             std::string::npos);
   ASSERT_EQ(0, s_crashes);
 }
 
 TEST_F(KernelCollectorTest, CollectNoCrash) {
   WriteStringToFile(test_kcrash_, "");
   ASSERT_FALSE(collector_.Collect());
@@ skipping 54 matching lines @@
   ASSERT_TRUE(file_util::ReadFileToString(FilePath(filename), &contents));
   ASSERT_EQ("something", contents);
 
   CheckPreservedDumpClear();
 }
 
 int main(int argc, char **argv) {
   ::testing::InitGoogleTest(&argc, argv);
   return RUN_ALL_TESTS();
 }