Issue 3436019: Added code in the browser process to display a Cloud Print token expired desk...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3436019: Added code in the browser process to display a Cloud Print token expired desk... (Closed)

Created:
10 years, 3 months ago by sanjeevr

Modified:
9 years, 7 months ago

Reviewers:
John Gregg, Scott Byer

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Added code in the browser process to display a Cloud Print token expired desktop notification. Also added a command-line switch to show this UI. BUG=None TEST=None for now. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60205

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : Fixed Linux build #

Total comments: 1

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -11 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_init.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/printing/cloud_print/cloud_print_proxy_service.h	View		2 chunks	+16 lines, -3 lines	0 comments	Download
M	chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc	View	1 2	2 chunks	+80 lines, -8 lines	1 comment	Download
M	chrome/common/chrome_switches.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sanjeevr

John, if you could take a quick glance at the code that uses the desktop ...

10 years, 3 months ago (2010-09-20 17:30:00 UTC) #1

Scott Byer

LGTM On 2010/09/20 17:30:00, sanjeevr wrote: > John, if you could take a quick glance ...

10 years, 3 months ago (2010-09-20 20:36:01 UTC) #2

John Gregg

10 years, 3 months ago (2010-09-21 23:57:55 UTC) #3

LGTM

http://codereview.chromium.org/3436019/diff/4002/15003
File chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc (right):

http://codereview.chromium.org/3436019/diff/4002/15003#newcode87
chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc:87:
Notification notification(GURL(), GURL(content_url), string16(), string16(),
just FYI, this notification will be shown without an origin URL since your first
argument is GURL().  I think that should be fine though and we can add a way to
give you a title.  (maybe add a todo, you can assign it to me if you want)

Expand Messages | Collapse Messages