Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 3436017: Remove unnecessary log spew from ProfileSyncService. (Closed)

Created:
10 years, 3 months ago by tim (not reviewing)
Modified:
9 years, 6 months ago
Reviewers:
akalin
CC:
chromium-reviews, Raghu Simha, ncarter (slow), idana, tim (not reviewing), ben+cc_chromium.org
Visibility:
Public.

Description

Remove unnecessary log spew from ProfileSyncService. BUG=none. TEST=examine logs from browser/ui/unit/interactive_ui tests, profile_sync_service should not be in top 20 spammers. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59848

Patch Set 1 #

Patch Set 2 : tweak layout #

Patch Set 3 : const& #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M chrome/browser/browser_about_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 5 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/sync/resources/about_sync.html View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tim (not reviewing)
10 years, 3 months ago (2010-09-17 20:16:18 UTC) #1
akalin
10 years, 3 months ago (2010-09-17 20:25:46 UTC) #2
LGTM

On 2010/09/17 20:16:18, timsteele wrote:
>

Powered by Google App Engine
This is Rietveld 408576698