Issue 3436010: Don't forget to umount rootfs in case we bail on firmware re-signing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3436010: Don't forget to umount rootfs in case we bail on firmware re-signing. (Closed)

Created:
10 years, 3 months ago by gauravsh

Modified:
9 years, 6 months ago

Reviewers:
Will Drewry

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@gitrw.chromium.org:9222/vboot_reference.git

Visibility:
Public.

Description

Don't forget to umount rootfs in case we bail on firmware re-signing. BUG=chrome-os-partner:1097 TEST=manual + independently verified by drewry@ 1) Extract rootfs from the original image. 2) run tune2fs -l <original rootfs> on it. Observe filesystem features has no "needs_recovery" 3) run sign_official_build.sh 4) Extract new rootfs 6) run tune2fs -l <new rootfs>. "needs_recovery" should still not be there (it was before this fix) Change-Id: I3a03245886844d3dbfe1f8b2b73ce624ec67808f

Patch Set 1 #

Patch Set 2 : remove spurious umount #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	scripts/image_signing/sign_official_build.sh	View	1	3 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

gauravsh

would you rather I keep the debug echo's or remove them? (i did but forgot ...

10 years, 3 months ago (2010-09-16 01:41:26 UTC) #3

Will Drewry

10 years, 3 months ago (2010-09-16 01:53:53 UTC) #4

doesn't matter to me. push which ever will make our lives easier :)

On Wed, Sep 15, 2010 at 8:41 PM, Gaurav Shah <gauravsh@chromium.org> wrote:
> would you rather I keep the debug echo's or remove them? (i did but
> forgot to git cl upload the patchset)
>
> On Wed, Sep 15, 2010 at 6:35 PM,  <wad@chromium.org> wrote:
>> LGTM extra debugging echo's and all :)
>>
>> http://codereview.chromium.org/3436010/show
>>
>
>
>
> --
> -g
>

Expand Messages | Collapse Messages