Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 3436006: Enhance SafeStackFrameIterator to avoid triggering assertions in debug mode. (Closed)

Created:
10 years, 3 months ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Enhance SafeStackFrameIterator to avoid triggering assertions in debug mode. When running profiling in debug mode, several assertions in frame iterators that are undoubtedly useful when iterator is started from a VM thread in a known "good" state, may fail when running over a stack of a suspended VM thread. This patch makes SafeStackFrameIterator to proactively check addresses and bail out from iteration early, before an assertion will be triggered. BUG=crbug/55565 Committed: http://code.google.com/p/v8/source/detail?r=5467

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -79 lines) Patch
M src/arm/frames-arm.cc View 1 chunk +2 lines, -11 lines 0 comments Download
M src/frames.h View 5 chunks +30 lines, -3 lines 0 comments Download
M src/frames.cc View 5 chunks +43 lines, -9 lines 0 comments Download
M src/ia32/frames-ia32.cc View 1 chunk +2 lines, -10 lines 0 comments Download
M src/log.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/mips/frames-mips.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/x64/frames-x64.cc View 1 chunk +2 lines, -12 lines 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 4 chunks +10 lines, -25 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mnaganov (inactive)
10 years, 3 months ago (2010-09-15 17:55:27 UTC) #1
Søren Thygesen Gjesse
10 years, 3 months ago (2010-09-16 06:49:15 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698