Issue 3435019: Store lower cased tag names withing webaccessibility.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3435019: Store lower cased tag names withing webaccessibility. (Closed)

Created:
10 years, 3 months ago by Chris Guillory

Modified:
9 years, 7 months ago

Reviewers:
dmazzoni

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Store lower case tag names within web accessibility. This is similar to the behavior of firefox. BUG=none TEST=browser_tests:RendererAccessibilityBrowserTest.TestCrossPlatformAccessibilityTree TEST=interactive_ui_tests:AccessibilityWinBrowserTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60259

Patch Set 1 #

Patch Set 2 : Update Tests #

Total comments: 1

Patch Set 3 : '' #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -10 lines)			Patch
M	chrome/browser/accessibility_win_browsertest.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/browser_accessibility_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/test/renderer_accessibility_browsertest.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	webkit/glue/webaccessibility.cc	View	2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dmazzoni

10 years, 3 months ago (2010-09-22 21:47:59 UTC) #2

LGTM.

http://codereview.chromium.org/3435019/diff/1001/2003
File webkit/glue/webaccessibility.cc (right):

http://codereview.chromium.org/3435019/diff/1001/2003#newcode309
webkit/glue/webaccessibility.cc:309: attributes[ATTR_HTML_TAG] =
StringToLowerASCII(string16(element.tagName()));
This is fine, but it's possible that other APIs will want the uppercase version
later, so we may end up wanting to do the case conversion in the Win or Mac
specific code.

Expand Messages | Collapse Messages