Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 3434005: CHROMIUMOS: mac80211: send last 3/5 probe requests as unicast (Closed)

Created:
10 years, 3 months ago by Paul Stewart
Modified:
9 years, 7 months ago
Reviewers:
Sam Leffler
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, sleffler+cc_chromium.org, Olof Johansson, vb
Base URL:
ssh://gitrw.chromium.org/kernel.git
Visibility:
Public.

Description

CHROMIUMOS: mac80211: send last 3/5 probe requests as unicast Some buggy APs do not respond to unicast probe requests or send unicast probe requests very delayed so in the worst case we should try to send broadcast probe requests, otherwise we can get disconnected from these APs. Even if drivers do not have filters to disregard probe responses from foreign APs mac80211 will only process probe responses from our associated AP for re-arming connection monitoring. We need to do this since the beacon monitor does not push back the connection monitor by design so even if we are getting beacons from these type of APs our connection monitor currently relies heavily on the way the probe requests are received on the AP. An example of an AP affected by this is the Nexus One, but this has also been observed with random APs. We can probably optimize this later by using null funcs instead of probe requests. For more details refer to: http://code.google.com/p/chromium-os/issues/detail?id=5715 This patch has fixes for stable kernels [2.6.35+]. Cc: stable@kernel.org Cc: Paul Stewart <pstew@google.com>; Cc: Amod Bodas <amod.bodas@atheros.com>; Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>; BUG=chromium-os:5715 TEST=Walkaround tests + SecMat and MatFunc testbed runs Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=651e9a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M chromeos/compat-wireless/net/mac80211/mlme.c View 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Stewart
10 years, 3 months ago (2010-09-15 19:31:19 UTC) #1
Sam Leffler
10 years, 3 months ago (2010-09-15 19:35:32 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698