Issue 3433001: Fix factory test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3433001: Fix factory test (Closed)

Created:
10 years, 3 months ago by Hung-Te

Modified:
9 years, 7 months ago

Reviewers:
Tammo Spalink, Tom Wai-Hong Tam

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/autotest.git

Visibility:
Public.

Description

Fix factory test On last integration we found two bugs which caused factory test program to halt. Here's the fixes. gbb_util: variable should be initialized. factory_UploadLogs: a variable has changed from global to class scope. BUG=none TEST=manually Change-Id: I40a24a6ed6601803a04352859e15886536f4eef0

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	client/common_lib/gbb_util.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	client/site_tests/factory_UploadLogs/factory_UploadLogs.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Thanks for fixing it.

Expand Messages | Collapse Messages