Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 3432032: Fix test after 64 bit heap size change. (Closed)

Created:
10 years, 2 months ago by Erik Corry
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

More correctness around PrintF and 32/64 bit values. Fix test after 64 bit heap size change. Committed: http://code.google.com/p/v8/source/detail?r=5543

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -60 lines) Patch
M src/arm/simulator-arm.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M src/assembler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/contexts.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/data-flow.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/disassembler.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/global-handles.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/heap.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/heap.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/heap-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mark-compact.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/objects-debug.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M src/regexp-macro-assembler-tracer.cc View 16 chunks +34 lines, -23 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/spaces.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/utils.h View 1 chunk +9 lines, -1 line 0 comments Download
M test/mjsunit/binary-op-newspace.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Erik Corry
10 years, 2 months ago (2010-09-28 10:45:46 UTC) #1
Erik Corry
10 years, 2 months ago (2010-09-28 11:31:47 UTC) #2
Vyacheslav Egorov (Chromium)
10 years, 2 months ago (2010-09-28 11:38:24 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698