Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 3431026: Add an AST node type enum to AST nodes. (Closed)

Created:
10 years, 3 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Add an AST node type enum to AST nodes. When inspecting an AST node in the debugger, it can be difficult to find its concrete type. Add a "node_type" virtual function to all the concrete AST nodes. Use a macro to generate the definition of node_type as well as Accept and the AsXXX type testing/casting functions. Committed: http://code.google.com/p/v8/source/detail?r=5549

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -114 lines) Patch
M src/ast.h View 43 chunks +71 lines, -114 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
10 years, 3 months ago (2010-09-24 09:24:30 UTC) #1
Erik Corry
10 years, 2 months ago (2010-09-28 08:00:07 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698