Issue 3431008: Consoldidate wifi test suite boilerplate into site_wifitest.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3431008: Consoldidate wifi test suite boilerplate into site_wifitest.py (Closed)

Created:
10 years, 3 months ago by Paul Stewart

Modified:
9 years, 7 months ago

Reviewers:
Sam Leffler

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org

Base URL:
ssh://gitrw.chromium.org/autotest.git

Visibility:
Public.

Description

Consoldidate wifi test suite boilerplate into site_wifitest.py Every time we create a wifi test suite, we have to copy the boilerplate code from a previous suite. In the spirit of DRY, I've consolidated things into a superclass for the .py code and a site_wifitest call for the control file. BUG=none TEST=rerun run_remote_tests

Patch Set 1 #

Patch Set 2 : Merge with error CL #

Patch Set 3 : Sneaky merge line fixed. #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -127 lines)			Patch
M	server/site_tests/network_WiFiMatFunc/control	View		1 chunk	+1 line, -24 lines	0 comments	Download
M	server/site_tests/network_WiFiMatFunc/network_WiFiMatFunc.py	View		1 chunk	+3 lines, -38 lines	0 comments	Download
M	server/site_tests/network_WiFiSecMat/control	View		1 chunk	+2 lines, -26 lines	0 comments	Download
M	server/site_tests/network_WiFiSecMat/network_WiFiSecMat.py	View		2 chunks	+4 lines, -39 lines	0 comments	Download
M	server/site_wifitest.py	View	1 2	2 chunks	+61 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM, this is a long time coming, thank you!

Expand Messages | Collapse Messages