Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 3431004: Allow prepackaged to still be passed and make learn_board work again (Closed)

Created:
10 years, 3 months ago by kmixter1
Modified:
9 years, 7 months ago
Reviewers:
zbehan
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Allow prepackaged to still be passed and make learn_board work again Change-Id: I664858ff9b931479fe2fac89a24aa3e7fce8493b BUG= TEST=ran rrt without ==board or default board set

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M run_remote_tests.sh View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kmixter1
10 years, 3 months ago (2010-09-15 00:07:15 UTC) #1
zbehan
10 years, 3 months ago (2010-09-15 00:09:42 UTC) #2
LGTM, thanks

On Tue, Sep 14, 2010 at 5:07 PM, <kmixter@chromium.org> wrote:

> Reviewers: zbehan,
>
> Description:
> Allow prepackaged to still be passed and make learn_board work again
>
> Change-Id: I664858ff9b931479fe2fac89a24aa3e7fce8493b
>
> BUG=
> TEST=ran rrt without ==board or default board set
>
> Please review this at http://codereview.chromium.org/3431004/show
>
> SVN Base: http://git.chromium.org/git/crosutils.git
>
> Affected files:
>  M run_remote_tests.sh
>
>
> Index: run_remote_tests.sh
> diff --git a/run_remote_tests.sh b/run_remote_tests.sh
> index
>
6eac70417a5ca7d4e2255fa2b11d4913517c55ad..f4f9df9be92946bda47d21246889577027ae0c34
> 100755
> --- a/run_remote_tests.sh
> +++ b/run_remote_tests.sh
> @@ -154,16 +154,14 @@ function main() {
>
>   remote_access_init
>
> -  # HACK: Temporary hack for cros-workon conversion
> -  # In cros-workon, we always use the prepackaged tests, because the
> locations
> -  # where tests come from are possibly infinite.
> -  [[ -n "${CROS_WORKON_SRCROOT}" ]] && \
> -    FLAGS_prepackaged_autotest="/build/${FLAGS_board}/usr/local/autotest/"
> -
>   local autotest_dir=""
>   if [[ -z "${FLAGS_prepackaged_autotest}" ]]; then
>     learn_board
> -    autotest_dir="${GCLIENT_ROOT}/src/third_party/autotest/files"
> +    if [[ -n "${CROS_WORKON_SRCROOT}" ]]; then
> +      autotest_dir="/build/${FLAGS_board}/usr/local/autotest"
> +    else
> +      autotest_dir="${GCLIENT_ROOT}/src/third_party/autotest/files"
> +    fi
>   else
>     autotest_dir="${FLAGS_prepackaged_autotest}"
>   fi
>
>
>

Powered by Google App Engine
This is Rietveld 408576698